Add forced-colors #1651
Merged
Add forced-colors #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
This was referenced Aug 23, 2024
Merged
captainbrosset
requested changes
Sep 2, 2024
| - https://drafts.csswg.org/css-color-adjust-1/#forced-color-adjust-prop | ||
| group: css | ||
| status: | ||
| compute_from: css.at-rules.media.forced-colors |
There was a problem hiding this comment.
Can you use the feature without forced-color-adjust? It seems that merely detecting forced colors mode without being able to change it wouldn't be useful.
I wonder if we should just remove the compute_from rule here.
There was a problem hiding this comment.
You can use it without forced-color-adjust. For example, you can add a border to a button if it otherwise gets styles from box-shadow, which is removed in forced colors mode. So, the at rule was functional before forced-color-adjust was added.
captainbrosset
approved these changes
Sep 3, 2024
ddbeck
approved these changes
Sep 5, 2024
|
Oh wait, I can't because push to the PR branch. Oops! — @jamesnw if you'd apply the fix, we can merge soon after. Thank you! |
Co-authored-by: Daniel D. Beck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1624